Update agent config: address review feedback from recent PRs#748
Merged
Update agent config: address review feedback from recent PRs#748
Conversation
github-actions
bot
added
needs-triage
needs-kind
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="self-development/kelos-pr-responder.yaml">
<violation number="1" location="self-development/kelos-pr-responder.yaml:90">
P2: Handle `KELOS_UPSTREAM_REPO` in the CI-check command, otherwise `gh pr checks` can target the wrong repo in upstream/fork workflows.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
kelos-bot
bot
changed the title
gjkim42
reviewed
Mar 22, 2026
self-development/agentconfig.yaml
Outdated
| - Logging conventions: start log messages with capital letters and do not end with punctuation | ||
| - Commit messages: do not include PR links in commit messages | ||
| - When making structural changes (adding new files, configs, or components), update related documentation (especially README files) to stay in sync | ||
| - When adding or changing API fields, also update self-development TaskSpawners (`self-development/*.yaml`) and example configs to use the new fields |
Collaborator
There was a problem hiding this comment.
Actually, it should be handled separately.
Remove it.
github-actions
bot
removed
the
needs-kind
Author
|
🤖 Kelos Task Status Task |
kelos-bot
bot
force-pushed
the
kelos-config-update-20260319-1800
branch
from
afa0333 to
d155925
Compare
Author
|
/kelos needs-input All review feedback addressed — removed the "API changes require config updates" convention from |
gjkim42
approved these changes
Mar 22, 2026
Collaborator
gjkim42
left a comment
gjkim42
left a comment
There was a problem hiding this comment.
Fix the review comments and squash commits
/kelos pick-up
AGENTS.md
Outdated
| - **Better tests.** Always try to add or improve tests(including integration, e2e) when modifying code. | ||
| - **Logging conventions.** Start log messages with capital letters and do not end with punctuation. | ||
| - **Commit messages.** Do not include PR links in commit messages. | ||
| - **API changes require config updates.** When adding or changing API fields, also update self-development TaskSpawners (`self-development/*.yaml`) and example configs to use the new fields. |
Author
|
🤖 Kelos Task Status Task |
- Add KELOS_UPSTREAM_REPO to CI check commands in kelos-pr-responder - Require make verify and make test in re-review loops - Add Kubernetes resource.Quantity comparison convention - Active CI status checking instead of passive instruction Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kelos-bot
bot
force-pushed
the
kelos-config-update-20260319-1800
branch
from
d155925 to
1a08a8a
Compare
Author
|
/kelos needs-input All review feedback was addressed in previous commits (the "API changes require config updates" convention was already removed from both AGENTS.md and agentconfig.yaml). PR description updated to reflect the final diff. Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates agent configuration based on review feedback from recent PRs:
Add
KELOS_UPSTREAM_REPOto CI check commands (kelos-pr-responder)gh pr checkscan target the wrong repo in upstream/fork workflows without--repo "$KELOS_UPSTREAM_REPO"Require
make verifyandmake testin re-review loops (kelos-pr-responder, kelos-workers)Add Kubernetes
resource.Quantitycomparison convention (AGENTS.md, agentconfig.yaml)reflect.DeepEqualmisdetected drift for equivalentresource.Quantityvalues because the struct has internal fields that differ for semantically identical quantities (e.g.,1000mvs1CPU). Adding this as a project convention to prevent recurrence.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
All review feedback has been addressed:
agentconfig.yamlandAGENTS.mdper reviewer request (to be handled separately)Does this PR introduce a user-facing change?